Bug 126068

Summary: Replace virtual isListBox functions with enum and standalone function
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: buildbot, gyuyoung.kim, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Description Antti Koivisto 2013-12-20 07:48:01 PST 
Fast and modern.
Comment 1 Antti Koivisto 2013-12-20 07:53:27 PST 
Created attachment 219757 [details]
patch
Comment 2 Andreas Kling 2013-12-20 08:00:19 PST 
Comment on attachment 219757 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219757&action=review

> Source/WebCore/ChangeLog:3
> +        Replace virtual isRenderFoo functions with bits and standalone functions

Title seems a bit broad when it's only for RenderListBox so far.
Comment 3 Antti Koivisto 2013-12-20 08:24:53 PST 
> Title seems a bit broad when it's only for RenderListBox so far.

It is an aspirational title!
Comment 4 Build Bot 2013-12-20 08:57:49 PST 
Comment on attachment 219757 [details]
patch

Attachment 219757 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/50568045

New failing tests:
editing/execCommand/format-block-multiple-paragraphs-in-pre.html
Comment 5 Build Bot 2013-12-20 08:57:51 PST 
Created attachment 219761 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5