| Summary: | [arm] Missing implementation of branchTest8(ResultCondition, BaseIndex, TrustedImm32) in MacroAssembler | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, mhahnenberg, msaboff, ossy, rgabor, zherczeg | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 219747 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL).
Comment on attachment 219747 [details]
Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL).
r=me
Comment on attachment 219747 [details] Add branchTest8(ResultCondition, BaseIndex, TrustedImm32) implementation in macro assembler for CPU(ARM_TRADITIONAL). Clearing flags on attachment: 219747 Committed r160911: <http://trac.webkit.org/changeset/160911> All reviewed patches have been landed. Closing bug. |
CPU(ARM_TRADITIONAL) build is broken: [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/JITPropertyAccess.cpp.o /nuxatlas6/local/jbriance/WebKit/cmake-arm/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In member function ‘JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Jump JSC::JIT::checkMarkWord(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID)’: /nuxatlas6/local/jbriance/WebKit/cmake-arm/webkit/Source/JavaScriptCore/jit/JITPropertyAccess.cpp:885:99: error: no matching function for call to ‘JSC::JIT::branchTest8(JSC::MacroAssemblerARM::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::BaseIndex)’ A patch similar to http://trac.webkit.org/changeset/160680 is needed for CPU(ARM_TRADITIONAL) architecture.