Bug 126059

Summary: Build fails in debug mode after r160834.
Product: WebKit Reporter: Tamas Gergely <tgergely.u-szeged>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Tamas Gergely
Reported 2013-12-20 00:30:34 PST
Compile error in debug mode: Source/WTF/wtf/dtoa/double-conversion.cc: In static member function 'static double WTF::double_conversion::StringToDoubleConverter::StringToDouble(const char*, size_t, size_t*)': Source/WTF/wtf/dtoa/double-conversion.cc:488:33: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Source/WTF/wtf/dtoa/double-conversion.cc:525:37: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Source/WTF/wtf/dtoa/double-conversion.cc:596:25: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
Attachments
patch (1.28 KB, patch)
2013-12-20 00:42 PST, Tamas Gergely 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tamas Gergely
Comment 1 2013-12-20 00:42:28 PST
Created attachment 219737 [details] patch
Csaba Osztrogonác
Comment 2 2013-12-20 02:22:24 PST
Comment on attachment 219737 [details] patch LGTM, r=me.
WebKit Commit Bot
Comment 3 2013-12-20 02:49:13 PST
Comment on attachment 219737 [details] patch Clearing flags on attachment: 219737 Committed r160899: <http://trac.webkit.org/changeset/160899>
WebKit Commit Bot
Comment 4 2013-12-20 02:49:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.