Bug 126053

Summary: Add a test for reattaching collapsed whitespace when siblings change style
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica, kling, koivisto, mmaxfield
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the test mitz: review+

Description Ryosuke Niwa 2013-12-19 22:08:29 PST 
Merge the test from https://chromium.googlesource.com/chromium/blink/+/dd5636728643ff958aebeaf064d38754b0d5904b
so that we may not introduce the same regression in WebKit.
Comment 1 Ryosuke Niwa 2013-12-19 22:11:32 PST 
Created attachment 219730 [details]
Adds the test
Comment 2 mitz 2013-12-20 18:36:01 PST 
Comment on attachment 219730 [details]
Adds the test

View in context: https://bugs.webkit.org/attachment.cgi?id=219730&action=review

> LayoutTests/fast/css/collapsed-whitespace-reattach-in-style-recalc.html:31
> +    shouldBeGreaterThanOrEqual('spans[spans.length - 1].offsetLeft', "400");

Is there a way to write this 400 as “more than half the width of ” something?
Comment 3 Ryosuke Niwa 2013-12-24 00:07:46 PST 
(In reply to comment #2)
> (From update of attachment 219730 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219730&action=review
> 
> > LayoutTests/fast/css/collapsed-whitespace-reattach-in-style-recalc.html:31
> > +    shouldBeGreaterThanOrEqual('spans[spans.length - 1].offsetLeft', "400");
> 
> Is there a way to write this 400 as “more than half the width of ” something?

Replaced it with container.offsetWidth * 2 / 3.
Comment 4 Ryosuke Niwa 2013-12-24 00:08:10 PST 
Committed r161052: <http://trac.webkit.org/changeset/161052>