Bug 126042

Summary: Clarify the behavior of composited canvases
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Description Simon Fraser (smfr) 2013-12-19 19:17:00 PST 
Clarify the behavior of composited canvases
Comment 1 Simon Fraser (smfr) 2013-12-19 19:20:12 PST 
Created attachment 219718 [details]
Patch
Comment 2 EFL EWS Bot 2013-12-19 19:26:20 PST 
Comment on attachment 219718 [details]
Patch

Attachment 219718 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/50208140
Comment 3 Tim Horton 2013-12-19 19:30:11 PST 
Comment on attachment 219718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219718&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:88
>  #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)

This #if needs to have a case for IOSurface-backed canvas too, otherwise if PLATFORM(MAC) were to compile WebGL out we'd always be returning UnacceleratedCanvas.

Or like you mentioned on IRC you might not need them at all.
Comment 4 Simon Fraser (smfr) 2013-12-19 19:34:51 PST 
Created attachment 219719 [details]
Patch
Comment 5 Simon Fraser (smfr) 2013-12-19 19:37:06 PST 
Created attachment 219720 [details]
Patch
Comment 6 Simon Fraser (smfr) 2013-12-19 19:38:06 PST 
*** Bug 126039 has been marked as a duplicate of this bug. ***
Comment 7 Simon Fraser (smfr) 2013-12-19 19:45:25 PST 
https://trac.webkit.org/r160894
Comment 8 Tim Horton 2013-12-19 21:29:34 PST 
Should HTMLCanvasElement::paintsIntoCanvasBuffer() reference this for clarity's sake?