Bug 126021

Summary: Different and incorrect flags are passed to sendSync when accessibility is enabled, SpinRunLoopWhileWaitingForReply
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: AccessibilityAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cfleizach, darin, mitz, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127411, 127429    
Bug Blocks:    
Attachments:
Description Flags
Get rid of SpinRunLoopWhileWaitingForReply darin: review+

Alexey Proskuryakov
Reported 2013-12-19 15:06:09 PST
In WebKit2, we have multiple places where sendSync flags depend on whether accessibility is enabled. unsigned syncSendFlags = (WebCore::AXObjectCache::accessibilityEnabled()) ? CoreIPC::SpinRunLoopWhileWaitingForReply : 0; WebProcess::shared().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptAlert(webFrame->frameID(), alertText), Messages::WebPageProxy::RunJavaScriptAlert::Reply(), m_page->pageID(), CoreIPC::Connection::NoTimeout, syncSendFlags); It is unfortunate to have such differences, because we get to support two runtime behaviors instead of one. I think that we should either make SpinRunLoopWhileWaitingForReply unconditional, or stop passing SpinRunLoopWhileWaitingForReply, and find different fixes for bugs it was needed for. Bug 126014 is one case where SpinRunLoopWhileWaitingForReply was found to cause significant trouble.
Attachments
Get rid of SpinRunLoopWhileWaitingForReply (14.46 KB, patch)
2015-12-20 08:23 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-12-19 15:32:09 PST
See also: bug 123828.
Radar WebKit Bug Importer
Comment 2 2013-12-19 15:32:21 PST
<rdar://problem/15703778>
Alexey Proskuryakov
Comment 3 2014-01-26 18:00:30 PST
Removing "possibly" from the title, as it's certainly incorrect given the test crashes seen in blocking bugs. Now that accessibility gets disabled after each test, this should affect testing, but it may cause instability in real life.
mitz
Comment 4 2015-12-20 08:23:54 PST
Created attachment 267719 [details] Get rid of SpinRunLoopWhileWaitingForReply
mitz
Comment 5 2015-12-21 07:17:37 PST
Committed <http://trac.webkit.org/r194330>.
Note You need to log in before you can comment on or make changes to this bug.