Summary: | Web Inspector: Uncaught Exception: NavigationSidebarPanel.js: ERROR: TypeError: undefined is not a function (evaluating 'representedObject.saveIdentityToCookie(candidateObjectCookie)') | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | burg, commit-queue, eflews.bot, graouts, gyuyoung.kim, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2013-12-19 14:14:06 PST
Seems like the issue crops up when the item I have selected in the Resources Navigation sidebar is a FolderTreeElement, like "Scripts". Yes. All new WebInspector.FolderTreeElement's are passed a representedObject of null or undefined. Eventually in TreeElement, that becomes just an empty object: this.representedObject = (representedObject || {}); Which is what I'm seeing here. Created attachment 219685 [details]
[PATCH] Proposed Fix
Comment on attachment 219685 [details] [PATCH] Proposed Fix Attachment 219685 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/50568041 Created attachment 219706 [details]
[PATCH] Proposed Fix
On IRC the feedback was we should still be resilient against a missing representedObject.saveIdentityToCookie. So I added the if check, and console.error warn if it didn't exist.
Comment on attachment 219706 [details] [PATCH] Proposed Fix Clearing flags on attachment: 219706 Committed r160888: <http://trac.webkit.org/changeset/160888> All reviewed patches have been landed. Closing bug. |