Bug 126015

Summary: Enable video on WinCairo port
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: bfulgham, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 8   
Bug Depends on: 126319    
Bug Blocks:    
Attachments:
Description Flags
Patch darin: review+

Alex Christensen
Reported 2013-12-19 13:55:11 PST
Let's enable video on the WinCairo port using GStreamer. People who want to build WinCairo without requiring GStreamer can still do that by removing ENABLE_MEDIA_CONTROLS_SCRIPT, ENABLE_VIDEO_TRACK, and ENABLE_VIDEO (or basically undoing this patch).
Attachments
Patch (1.75 KB, patch)
2013-12-19 13:55 PST, Alex Christensen 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-12-19 13:55:52 PST
Created attachment 219680 [details] Patch
Philippe Normand
Comment 2 2013-12-20 05:38:39 PST
Comment on attachment 219680 [details] Patch I have no idea about the VS build system but can these options be disabled via build-webkit like in other ports?
Alex Christensen
Comment 3 2013-12-20 10:07:17 PST
There is not. This is as simple as I could make the enabling and disabling. You could do a string replace on this file before building, but then there would be changes in WebKitLibraries. It would be somewhat complicated to put these feature defines in WebKitBuild. I think this is a good solution, unless someone can think of a better one.
Philippe Normand
Comment 4 2013-12-23 07:25:56 PST
Ok then, I'll let Brent review this. Good work, it's nice to finally this land in trunk!
Alex Christensen
Comment 5 2013-12-30 18:44:28 PST
How do I add the gstreamer binaries and development binaries as a dependency in http://www.webkit.org/building/tools.html ? I'd like to do that before putting this in. Applewin requires QuickTime and wincairo requires gstreamer or reversing this patch.
Alex Christensen
Comment 6 2014-01-03 09:34:07 PST
http://trac.webkit.org/changeset/161266
Note You need to log in before you can comment on or make changes to this bug.