| Summary: | Enable video on WinCairo port | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <alex.christensen> | ||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | bfulgham, pnormand | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 8 | ||||||
| Bug Depends on: | 126319 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2013-12-19 13:55:11 PST
Created attachment 219680 [details]
Patch
Comment on attachment 219680 [details]
Patch
I have no idea about the VS build system but can these options be disabled via build-webkit like in other ports?
There is not. This is as simple as I could make the enabling and disabling. You could do a string replace on this file before building, but then there would be changes in WebKitLibraries. It would be somewhat complicated to put these feature defines in WebKitBuild. I think this is a good solution, unless someone can think of a better one. Ok then, I'll let Brent review this. Good work, it's nice to finally this land in trunk! How do I add the gstreamer binaries and development binaries as a dependency in http://www.webkit.org/building/tools.html ? I'd like to do that before putting this in. Applewin requires QuickTime and wincairo requires gstreamer or reversing this patch. |