Bug 126010

Summary:

GPRInfo references should be protected with ENABLE(JIT)

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Trivial

CC:

fpizlo, mhahnenberg

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	none

Description Alex Christensen 2013-12-19 12:53:16 PST

http://trac.webkit.org/changeset/160796/trunk/Source/JavaScriptCore/runtime/VM.h broke the Win64 build.  Here's the fix.

Comment 1 Filip Pizlo 2013-12-19 12:54:17 PST

I don't like adding more #if ENABLE(JIT)'s.  Can't you just create a dummy stub GPRInfo?

Comment 2 Alex Christensen 2013-12-19 12:55:56 PST

Created attachment 219678 [details]
Patch

Comment 3 Alex Christensen 2013-12-19 12:57:07 PST

(In reply to comment #1)
> I don't like adding more #if ENABLE(JIT)'s.  Can't you just create a dummy stub GPRInfo?
Should this array even be in VM.h?

Comment 4 Filip Pizlo 2013-12-19 13:04:59 PST

(In reply to comment #3)
> (In reply to comment #1)
> > I don't like adding more #if ENABLE(JIT)'s.  Can't you just create a dummy stub GPRInfo?
> Should this array even be in VM.h?

No, it shouldn't.  I don't think we need it.

Comment 5 Mark Hahnenberg 2013-12-19 13:09:54 PST

See bug 126012.

Comment 6 Alex Christensen 2013-12-19 13:50:48 PST

I'll let you fix this in the other bug, then.