Summary: | [GTK] Some unit tests using web extensions fail when run alone | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, gustavo, mrobinson | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 126006 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2013-12-19 11:42:17 PST
Created attachment 219668 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 219668 [details]
Patch
Quite clean. You could drop the type from the constructor and infer it based on which constructor gets selected (no URL => document loaded, URL => uri changed), but I think I prefer the explicit one, it's more future proof too.
(In reply to comment #3) > (From update of attachment 219668 [details]) > Quite clean. You could drop the type from the constructor and infer it based on which constructor gets selected (no URL => document loaded, URL => uri changed), but I think I prefer the explicit one, it's more future proof too. Thanks for the review. Committed r160904: <http://trac.webkit.org/changeset/160904> |