Bug 126001

Summary: tryAddEventListener uses local PassRefPtr<>
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Description Eric Carlson 2013-12-19 11:26:04 PST 
r160679 added a second use of a PassRefPtr<EventListener> parameter.
Comment 1 Eric Carlson 2013-12-19 11:34:21 PST 
Created attachment 219666 [details]
Proposed patch
Comment 2 Daniel Bates 2013-12-19 11:36:42 PST 
Comment on attachment 219666 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219666&action=review

> Source/WebCore/ChangeLog:10
> +            because it is sometimes used twice.

Nit: This line begins with extraneous whitespace.
Comment 3 Daniel Bates 2013-12-19 11:37:22 PST 
(In reply to comment #2)
> (From update of attachment 219666 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219666&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +            because it is sometimes used twice.
> 
> Nit: This line begins with extraneous whitespace.

This is OK as-is. I take it you feel this improves the readability of the change log entry.
Comment 4 Eric Carlson 2013-12-19 11:39:53 PST 
Committed r160849: https://trac.webkit.org/r160849