Bug 125985

Summary: Test that text-decoration-skip: ink is the same as regular underlines if no descenders
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2013-12-19 00:29:58 PST
Test that text-decoration-skip: ink is the same as regular underlines if no descenders
Attachments
Patch (2.91 KB, patch)
2013-12-19 00:31 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2013-12-19 14:56 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2013-12-19 00:31:14 PST
Created attachment 219630 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-12-19 14:54:35 PST
Comment on attachment 219630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219630&action=review > LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders-expected.html:1 > +<!DOCTYPE HTML> Minor preference for <!DOCTYPE html> > LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders-expected.html:8 > +<div style="display: inline-block; -webkit-transform: scale(5); -webkit-transform-origin: left top; -webkit-text-decoration-line: underline">NO DESCENDERS</div> Please use text-decoration: underline > LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders.html:8 > +<div style="display: inline-block; -webkit-text-decoration-skip: ink; -webkit-transform: scale(5); -webkit-transform-origin: left top; -webkit-text-decoration-line: underline">NO DESCENDERS</div> Ditto.
Myles C. Maxfield
Comment 3 2013-12-19 14:56:20 PST
Created attachment 219686 [details] Patch
WebKit Commit Bot
Comment 4 2013-12-19 15:21:14 PST
Comment on attachment 219686 [details] Patch Clearing flags on attachment: 219686 Committed r160865: <http://trac.webkit.org/changeset/160865>
WebKit Commit Bot
Comment 5 2013-12-19 15:21:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.