Bug 125968

Summary:

CSS: Fall back to cache-less cascade when encountering explicitly inherited value.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2013-12-18 18:32:29 PST

Three asserting tests:

http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r160806%20(1196)/results.html

Comment 1 Andreas Kling 2013-12-18 18:33:13 PST

Created attachment 219600 [details]
Patch

Bit quick, bit dirty.

Comment 2 Antti Koivisto 2013-12-18 18:39:06 PST

Comment on attachment 219600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219600&action=review

> Source/WebCore/css/StyleResolver.cpp:4273
> +bool StyleResolver::CascadedProperties::addMatches(const MatchResult& matchResult, bool important, int startIndex, int endIndex, bool inheritedOnly)

Argument return might end up reading better.

Comment 3 WebKit Commit Bot 2013-12-18 19:10:00 PST

Comment on attachment 219600 [details]
Patch

Clearing flags on attachment: 219600

Committed r160820: <http://trac.webkit.org/changeset/160820>

Comment 4 WebKit Commit Bot 2013-12-18 19:10:02 PST

All reviewed patches have been landed.  Closing bug.