Bug 125958

Summary:

Final preparations for GStreamer on Windows

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, jer.noble, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2013-12-18 16:11:17 PST

I would like to make the final change to enable video on Windows just be adding #define ENABLE_VIDEO. I'll submit that patch and ask webkit-dev what they think. To do that, I need to remove the requirement for VIDEO_TRACK to require VIDEO. This patch prepares us for such a dramatic switch.

Attachments
Patch (3.77 KB, patch) 2013-12-18 16:17 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (3.79 KB, patch) 2013-12-18 16:22 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (3.93 KB, patch) 2013-12-18 22:55 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (3.93 KB, patch) 2013-12-19 11:19 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-12-18 16:17:39 PST

Created attachment 219582 [details] Patch

Alex Christensen

Comment 2 2013-12-18 16:22:10 PST

Created attachment 219583 [details] Patch

Alex Christensen

Comment 3 2013-12-18 16:31:14 PST

Comment on attachment 219583 [details] Patch This causes compile errors. There are a few places where VIDEO_TRACK assumes VIDEO

Alex Christensen

Comment 4 2013-12-18 22:54:50 PST

Oh yeah, and it's a terrible idea to not have VIDEO_TRACK require VIDEO. I'm going to do this, and make the final switch turning on video in FeatureDefinesCairo.props instead of FeatureDefines.h.

Alex Christensen

Comment 5 2013-12-18 22:55:35 PST

Created attachment 219619 [details] Patch

Roger Fong

Comment 6 2013-12-19 10:37:17 PST

Unofficial r+ here, will ping Brent to give the final thumbs up

Brent Fulgham

Comment 7 2013-12-19 11:14:04 PST

Comment on attachment 219619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219619&action=review Please use the $(WebKit_Libraries) variable instead of the relative paths. > Source/WTF/WTF.vcxproj/WTFDebugWinCairo.props:9 > + <Import Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" /> This should be "$(WebKit_Libraries)\tools\..." > Source/WTF/WTF.vcxproj/WTFReleaseWinCairo.props:9 > + <Import Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" /> Ditto. > Source/WTF/wtf/Platform.h:908 > +#define WTF_USE_GLIB 1 :-(

Alex Christensen

Comment 8 2013-12-19 11:19:00 PST

Created attachment 219662 [details] Patch

WebKit Commit Bot

Comment 9 2013-12-19 13:34:57 PST

Comment on attachment 219662 [details] Patch Clearing flags on attachment: 219662 Committed r160855: <http://trac.webkit.org/changeset/160855>

WebKit Commit Bot

Comment 10 2013-12-19 13:34:59 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.