Bug 125958

Summary:

Final preparations for GStreamer on Windows

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, jer.noble, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Description Alex Christensen 2013-12-18 16:11:17 PST

I would like to make the final change to enable video on Windows just be adding #define ENABLE_VIDEO.  I'll submit that patch and ask webkit-dev what they think.  To do that, I need to remove the requirement for VIDEO_TRACK to require VIDEO.  This patch prepares us for such a dramatic switch.

Comment 1 Alex Christensen 2013-12-18 16:17:39 PST

Created attachment 219582 [details]
Patch

Comment 2 Alex Christensen 2013-12-18 16:22:10 PST

Created attachment 219583 [details]
Patch

Comment 3 Alex Christensen 2013-12-18 16:31:14 PST

Comment on attachment 219583 [details]
Patch

This causes compile errors.  There are a few places where VIDEO_TRACK assumes VIDEO

Comment 4 Alex Christensen 2013-12-18 22:54:50 PST

Oh yeah, and it's a terrible idea to not have VIDEO_TRACK require VIDEO.

I'm going to do this, and make the final switch turning on video in FeatureDefinesCairo.props instead of FeatureDefines.h.

Comment 5 Alex Christensen 2013-12-18 22:55:35 PST

Created attachment 219619 [details]
Patch

Comment 6 Roger Fong 2013-12-19 10:37:17 PST

Unofficial r+ here, will ping Brent to give the final thumbs up

Comment 7 Brent Fulgham 2013-12-19 11:14:04 PST

Comment on attachment 219619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219619&action=review

Please use the $(WebKit_Libraries) variable instead of the relative paths.

> Source/WTF/WTF.vcxproj/WTFDebugWinCairo.props:9
> +    <Import Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" />

This should be "$(WebKit_Libraries)\tools\..."

> Source/WTF/WTF.vcxproj/WTFReleaseWinCairo.props:9
> +    <Import Project="..\..\..\WebKitLibraries\win\tools\vsprops\WinCairo.props" />

Ditto.

> Source/WTF/wtf/Platform.h:908
> +#define WTF_USE_GLIB 1

:-(

Comment 8 Alex Christensen 2013-12-19 11:19:00 PST

Created attachment 219662 [details]
Patch

Comment 9 WebKit Commit Bot 2013-12-19 13:34:57 PST

Comment on attachment 219662 [details]
Patch

Clearing flags on attachment: 219662

Committed r160855: <http://trac.webkit.org/changeset/160855>

Comment 10 WebKit Commit Bot 2013-12-19 13:34:59 PST

All reviewed patches have been landed.  Closing bug.