Bug 125941

Summary:

Add Obj C API for injected bundle PageGroup class.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, mitz, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add Obj C API (WKWebProcessPlugInPageGroup) for injected bundle PageGroup class.	none
Use _bundlePageGroup->identifier() directly, instead of going through WFStringRef wrapper.	mitz: review+
Fix style issue and address review comments before landing.	none

Yongjun Zhang

Reported 2013-12-18 12:51:35 PST

Need an Obj C API for injected bundle PageGroup class, and a method to expose the page group object from WKWebProcessPlugInBrowsingContextController.

Attachments
Add Obj C API (WKWebProcessPlugInPageGroup) for injected bundle PageGroup class. (17.14 KB, patch) 2013-12-18 12:57 PST, Yongjun Zhang	no flags	Details Formatted Diff Diff
Use _bundlePageGroup->identifier() directly, instead of going through WFStringRef wrapper. (17.06 KB, patch) 2013-12-18 14:08 PST, Yongjun Zhang	mitz: review+	Details Formatted Diff Diff
Fix style issue and address review comments before landing. (17.23 KB, patch) 2013-12-18 15:11 PST, Yongjun Zhang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2013-12-18 12:57:18 PST

Created attachment 219562 [details] Add Obj C API (WKWebProcessPlugInPageGroup) for injected bundle PageGroup class.

mitz

Comment 2 2013-12-18 13:21:45 PST

Comment on attachment 219562 [details] Add Obj C API (WKWebProcessPlugInPageGroup) for injected bundle PageGroup class. View in context: https://bugs.webkit.org/attachment.cgi?id=219562&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:46 > + WKStringRef string = toCopiedAPI(_bundlePageGroup->identifier()); > + return [wrapper(*toImpl(string)) autorelease]; You should be able to just return _bundlePageGroup->identifier(), since WTF::String converts to an NSString *.

Yongjun Zhang

Comment 3 2013-12-18 14:08:47 PST

Created attachment 219566 [details] Use _bundlePageGroup->identifier() directly, instead of going through WFStringRef wrapper.

mitz

Comment 4 2013-12-18 14:49:02 PST

Comment on attachment 219566 [details] Use _bundlePageGroup->identifier() directly, instead of going through WFStringRef wrapper. View in context: https://bugs.webkit.org/attachment.cgi?id=219566&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:35 > +- (NSString *)identifier; This is probably better expressed as @property (readonly) NSString *identifier; > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:34 > +#import "WKAPICast.h" > +#import "WKNSString.h" > +#import "WKRetainPtr.h" Probably don’t need these anymore. > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:47 > +@property(readonly) WKWebProcessPlugInFrame *mainFrame; > + > +@property(readonly) WKWebProcessPlugInPageGroup *pageGroup; There needs to be a space before the (, even though some existing code is wrong.

Yongjun Zhang

Comment 5 2013-12-18 15:11:37 PST

Created attachment 219576 [details] Fix style issue and address review comments before landing.

WebKit Commit Bot

Comment 6 2013-12-18 15:47:02 PST

Comment on attachment 219576 [details] Fix style issue and address review comments before landing. Clearing flags on attachment: 219576 Committed r160803: <http://trac.webkit.org/changeset/160803>

WebKit Commit Bot

Comment 7 2013-12-18 15:47:04 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.