Bug 125936

Summary:

WTF fails to compile with gcc 4.8.2 and -Werror=array-bounds

Product:

WebKit

Reporter:

Hugo Parente Lima <hugo.lima>

Component:

Web Template Framework

Assignee:

Hugo Parente Lima <hugo.lima>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Hugo Parente Lima 2013-12-18 11:55:33 PST

There's the error:

Source/WTF/wtf/dtoa/double-conversion.cc:597:26: error: array subscript is above array bounds [-Werror=array-bounds]

"buffer[buffer_pos] = '\0';"

Just because buffer_pos a int instead of an unsigned int.

Comment 1 Hugo Parente Lima 2013-12-18 12:00:05 PST

Created attachment 219555 [details]
Patch

Comment 2 WebKit Commit Bot 2013-12-19 09:08:17 PST

Comment on attachment 219555 [details]
Patch

Clearing flags on attachment: 219555

Committed r160834: <http://trac.webkit.org/changeset/160834>

Comment 3 WebKit Commit Bot 2013-12-19 09:08:22 PST

All reviewed patches have been landed.  Closing bug.