Bug 125904

Summary:

Do not create cue subtree just to delete it

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, gyuyoung.kim, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Description Eric Carlson 2013-12-17 18:41:39 PST

TextTrackCue creates its display lazily, so it might be NULL when removeDisplayTree or setActive(false) is called. Don't bother creating the display tree if we only want to delete it.

Comment 1 Eric Carlson 2013-12-18 10:10:51 PST

Created attachment 219543 [details]
Proposed patch

Comment 2 Jer Noble 2013-12-18 10:12:08 PST

Comment on attachment 219543 [details]
Proposed patch

r=me.

Comment 3 WebKit Commit Bot 2013-12-18 10:29:41 PST

Comment on attachment 219543 [details]
Proposed patch

Clearing flags on attachment: 219543

Committed r160777: <http://trac.webkit.org/changeset/160777>

Comment 4 WebKit Commit Bot 2013-12-18 10:29:43 PST

All reviewed patches have been landed.  Closing bug.