Bug 125901

Summary:

Web Inspector: Some basic DebuggerAgent cleanup

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector (Deprecated)

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, graouts, gyuyoung.kim, joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2013-12-17 18:28:08 PST

Some cleanup of DebuggerAgent. • Inline a function only called in one place. • Remove unnecessary virtual. • Remove private enabled() function and just use member variable.

Attachments
[PATCH] Proposed Fix (3.73 KB, patch) 2013-12-17 18:30 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2013-12-17 18:30:34 PST

Created attachment 219484 [details] [PATCH] Proposed Fix

EFL EWS Bot

Comment 2 2013-12-17 19:15:56 PST

Comment on attachment 219484 [details] [PATCH] Proposed Fix Attachment 219484 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/47478062

Joseph Pecoraro

Comment 3 2013-12-18 10:54:08 PST

Comment on attachment 219484 [details] [PATCH] Proposed Fix efl-wk2 bot looks like it was cancelled. I'm going to cq+.

WebKit Commit Bot

Comment 4 2013-12-18 11:22:57 PST

Comment on attachment 219484 [details] [PATCH] Proposed Fix Clearing flags on attachment: 219484 Committed r160780: <http://trac.webkit.org/changeset/160780>

WebKit Commit Bot

Comment 5 2013-12-18 11:22:59 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.