| Summary: | [MSE] Add per-track signalling between SourceBuffer and SourceBufferPrivate. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, glenn | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 125905 | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2013-12-17 18:22:23 PST
Created attachment 219485 [details]
Patch
Comment on attachment 219485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219485&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.h:143 > + struct TrackBuffer; Don't we usually forward declare structs and classes above the class? (In reply to comment #2) > (From update of attachment 219485 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219485&action=review > > > Source/WebCore/Modules/mediasource/SourceBuffer.h:143 > > + struct TrackBuffer; > > Don't we usually forward declare structs and classes above the class? Usually, yes, but this is a nested struct. It has to be declared within the declaration of SourceBuffer. Comment on attachment 219485 [details] Patch Clearing flags on attachment: 219485 Committed r160754: <http://trac.webkit.org/changeset/160754> All reviewed patches have been landed. Closing bug. |