Bug 125872

Summary: DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction"
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jsbell
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 ap: review+

Brady Eidson
Reported 2013-12-17 14:05:24 PST
DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction"
Attachments
Patch v1 (26.14 KB, patch)
2013-12-17 14:10 PST, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-12-17 14:10:27 PST
Created attachment 219452 [details] Patch v1
Alexey Proskuryakov
Comment 2 2013-12-17 15:00:38 PST
Comment on attachment 219452 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=219452&action=review > Source/WebCore/Modules/indexeddb/IndexedDB.h:41 > enum TransactionMode { > + TransactionModeMinimum = 0, > TransactionReadOnly = 0, > TransactionReadWrite = 1, > - TransactionVersionChange = 2 > + TransactionVersionChange = 2, > + TransactionModeMaximum = 2, > }; I'd use an enum class now: enum class TransactionMode { ReadOnly = 0, ReadWrite = 1 VersionChange = 2, }; const unsigned maximumTransactionMode = 2; (not sure why the minimum can't just be assumed 0).
Brady Eidson
Comment 3 2013-12-17 16:09:50 PST
http://trac.webkit.org/changeset/160732
Note You need to log in before you can comment on or make changes to this bug.