| Summary: | DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, commit-queue, jsbell | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 124521 | ||||||
| Attachments: |
|
||||||
|
Description
Brady Eidson
2013-12-17 14:05:24 PST
Created attachment 219452 [details]
Patch v1
Comment on attachment 219452 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=219452&action=review > Source/WebCore/Modules/indexeddb/IndexedDB.h:41 > enum TransactionMode { > + TransactionModeMinimum = 0, > TransactionReadOnly = 0, > TransactionReadWrite = 1, > - TransactionVersionChange = 2 > + TransactionVersionChange = 2, > + TransactionModeMaximum = 2, > }; I'd use an enum class now: enum class TransactionMode { ReadOnly = 0, ReadWrite = 1 VersionChange = 2, }; const unsigned maximumTransactionMode = 2; (not sure why the minimum can't just be assumed 0). |