Bug 125853 – prepare-ChangeLog doesn't handle templates properly

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

A simple diff:
---------------
diff --git a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
index bbcddd2..d3863d6 100644
--- a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
+++ b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
@@ -41,6 +41,7 @@ namespace CoreIPC {

 void ArgumentCoder<ResourceRequest>::encodePlatformData(ArgumentEncoder& encoder, const ResourceRequest& resourceRequest)
 {
+    // foo
     encoder << static_cast<uint32_t>(resourceRequest.soupMessageFlags());
 }

The generated ChangeLog entry:
-------------------------------
        * Shared/soup/WebCoreArgumentCodersSoup.cpp:
        (CoreIPC::::encodePlatformData):

[Dániel Bátyai]

Created attachment 219512 [details]
Proposed patch

[Dániel Bátyai]

Created attachment 219513 [details]
Proposed patch

[Peter Gal]

Comment on attachment 219513 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219513&action=review

> Tools/ChangeLog:3
> +        Fixed template handling in prepare-ChangeLog

This line does not match the bug entry's title.

[Dániel Bátyai]

Created attachment 219530 [details]
Proposed patch

[Csaba Osztrogonác]

Comment on attachment 219530 [details]
Proposed patch

The fix looks good to me, but please add a unittest.

[Dániel Bátyai]

Created attachment 219537 [details]
Proposed patch

[WebKit Commit Bot]

Comment on attachment 219537 [details]
Proposed patch

Clearing flags on attachment: 219537

Committed r160769: <http://trac.webkit.org/changeset/160769>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.