| Summary: | prepare-ChangeLog doesn't handle templates properly | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, dbates, dbatyai.u-szeged, gbalogh.u-szeged, ossy, zherczeg | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 219512 [details]
Proposed patch
Created attachment 219513 [details]
Proposed patch
Comment on attachment 219513 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219513&action=review > Tools/ChangeLog:3 > + Fixed template handling in prepare-ChangeLog This line does not match the bug entry's title. Created attachment 219530 [details]
Proposed patch
Comment on attachment 219530 [details]
Proposed patch
The fix looks good to me, but please add a unittest.
Created attachment 219537 [details]
Proposed patch
Comment on attachment 219537 [details] Proposed patch Clearing flags on attachment: 219537 Committed r160769: <http://trac.webkit.org/changeset/160769> All reviewed patches have been landed. Closing bug. |
A simple diff: --------------- diff --git a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp index bbcddd2..d3863d6 100644 --- a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp +++ b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp @@ -41,6 +41,7 @@ namespace CoreIPC { void ArgumentCoder<ResourceRequest>::encodePlatformData(ArgumentEncoder& encoder, const ResourceRequest& resourceRequest) { + // foo encoder << static_cast<uint32_t>(resourceRequest.soupMessageFlags()); } The generated ChangeLog entry: ------------------------------- * Shared/soup/WebCoreArgumentCodersSoup.cpp: (CoreIPC::::encodePlatformData):