DatabaseProcess: Plumb through messaging for the 4 basic transaction operations

• Component: WebKit2
• Status: RESOLVED FIXED

[Brady Eidson]

DatabaseProcess: Plumb through messaging for the 4 basic transaction operations

[Brady Eidson]

Created attachment 219370 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 219370 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=219370&action=review

r=me

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:234
> +        LOG_ERROR("Attempting to queue transaction operation when an operation is already pending");

An operation or the operation? Should it be an assertion?

I guess I'm not sure what this error means, besides "ping Brady on IRC" :)

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:255
> +

Looks like too much whitespace.

[Brady Eidson]

(In reply to comment #2)
> (From update of attachment 219370 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219370&action=review
> 
> r=me
> 
> > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:234
> > +        LOG_ERROR("Attempting to queue transaction operation when an operation is already pending");
> 
> An operation or the operation? Should it be an assertion?

"an" operation.

The reason this is not an ASSERT is because it directly relies on an ID that was sent over the wire from another process, so it can't be trusted as an invariant.

Will try to clarify the error message.

> > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:255
> > +

Yup!  Thanks!

[Brady Eidson]

http://trac.webkit.org/changeset/160678