Bug 125816

Summary: DatabaseProcess: Plumb through messaging for the 4 basic transaction operations
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 ap: review+

Brady Eidson
Reported 2013-12-16 16:41:06 PST
DatabaseProcess: Plumb through messaging for the 4 basic transaction operations
Attachments
Patch v1 (28.18 KB, patch)
2013-12-16 16:46 PST, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-12-16 16:46:53 PST
Created attachment 219370 [details] Patch v1
Alexey Proskuryakov
Comment 2 2013-12-16 17:01:42 PST
Comment on attachment 219370 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=219370&action=review r=me > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:234 > + LOG_ERROR("Attempting to queue transaction operation when an operation is already pending"); An operation or the operation? Should it be an assertion? I guess I'm not sure what this error means, besides "ping Brady on IRC" :) > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:255 > + Looks like too much whitespace.
Brady Eidson
Comment 3 2013-12-16 17:06:15 PST
(In reply to comment #2) > (From update of attachment 219370 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219370&action=review > > r=me > > > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:234 > > + LOG_ERROR("Attempting to queue transaction operation when an operation is already pending"); > > An operation or the operation? Should it be an assertion? "an" operation. The reason this is not an ASSERT is because it directly relies on an ID that was sent over the wire from another process, so it can't be trusted as an invariant. Will try to clarify the error message. > > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:255 > > + Yup! Thanks!
Brady Eidson
Comment 4 2013-12-16 17:09:21 PST
http://trac.webkit.org/changeset/160678
Note You need to log in before you can comment on or make changes to this bug.