Bug 125808

Summary: GraphicsContext3D too awesome for VS2013
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, kondapallykalyan, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 8   
Attachments:
Description Flags
Patch darin: review+

Alex Christensen
Reported 2013-12-16 15:26:59 PST
When compiling GraphicsContext3D.cpp in VS2013, I get error C1063. http://msdn.microsoft.com/en-us/library/aa229021(v=vs.60).aspx Can GraphicsContext3D.cpp be split up at all? I thought maybe the pack functions could be put into one source file, the unpacks into another, but that would defeat the whole purpose of having these inline functions. Is there another logical division?
Attachments
Patch (1.60 KB, patch)
2013-12-16 18:52 PST, Alex Christensen 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-12-16 18:52:55 PST
Created attachment 219381 [details] Patch
Darin Adler
Comment 2 2013-12-17 09:10:56 PST
Comment on attachment 219381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219381&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1614 > +// Visual Studio crashes with a C1063 Fatal Error if this is inlined. > +#if COMPILER(MSVC) > +#define ALWAYS_INLINE_EXCEPT_MSVC > +#else > +#define ALWAYS_INLINE_EXCEPT_MSVC ALWAYS_INLINE > +#endif I’d stick this at the top of the file, not way down here.
Alex Christensen
Comment 3 2013-12-17 10:11:22 PST
http://trac.webkit.org/changeset/160713
Note You need to log in before you can comment on or make changes to this bug.