Bug 125808

Summary:

GraphicsContext3D too awesome for VS2013

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, kondapallykalyan, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 8

Attachments:

Description	Flags
Patch	darin: review+

Description Alex Christensen 2013-12-16 15:26:59 PST

When compiling GraphicsContext3D.cpp in VS2013, I get error C1063.  http://msdn.microsoft.com/en-us/library/aa229021(v=vs.60).aspx

Can GraphicsContext3D.cpp be split up at all?  I thought maybe the pack functions could be put into one source file, the unpacks into another, but that would defeat the whole purpose of having these inline functions.  Is there another logical division?

Comment 1 Alex Christensen 2013-12-16 18:52:55 PST

Created attachment 219381 [details]
Patch

Comment 2 Darin Adler 2013-12-17 09:10:56 PST

Comment on attachment 219381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219381&action=review

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1614
> +// Visual Studio crashes with a C1063 Fatal Error if this is inlined.
> +#if COMPILER(MSVC)
> +#define ALWAYS_INLINE_EXCEPT_MSVC
> +#else
> +#define ALWAYS_INLINE_EXCEPT_MSVC ALWAYS_INLINE
> +#endif

I’d stick this at the top of the file, not way down here.

Comment 3 Alex Christensen 2013-12-17 10:11:22 PST

http://trac.webkit.org/changeset/160713