Bug 125807 – Apply overhang shadow and linen to UI-side layers

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Apply overhand shadow and linen to UI-side layers

[Simon Fraser (smfr)]

Created attachment 219358 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 219359 [details]
Patch

[Tim Horton]

Comment on attachment 219359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219359&action=review

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:560
> +    RetainPtr<CGPathRef> shadowPath = adoptCF(CGPathCreateWithRect(layer.bounds, NULL));
> +    layer.shadowPath = shadowPath.get();

not sure this temporary is useful

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:565
> +    layer.shadowPath = nil;

I think you should drop shadow opacity too, otherwise CA will try to figure out the opaque region of the layer because it doesn't have a shadowPath.

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:652
> +        if (layerProperties.changedProperties & RemoteLayerTreeTransaction::CustomAppearanceChanged)
> +            dumpProperty<GraphicsLayer::CustomAppearance>(ts, "customAppearance", layerProperties.customAppearance);
> +

Ideally this would print something useful but not necessary right now.

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:529
> +void PlatformCALayerRemote::updateCustomAppearance(WebCore::GraphicsLayer::CustomAppearance customAppearance)

No WebCore:: here

[Simon Fraser (smfr)]

<rdar://problem/15662167>

[Simon Fraser (smfr)]

https://trac.webkit.org/r160672

[Tim Horton]

This seems to have disappeared the shadow in traditional compositing. Not sure why, yet.