Summary: | Additional refinement in MathMLSelectElement toggle implementation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | MathML | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dbarton, fred.wang, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 120059 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Darin Adler
2013-12-16 10:17:18 PST
Created attachment 219326 [details]
Patch
Comment on attachment 219326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review > Source/WebCore/mathml/MathMLSelectElement.cpp:161 > // We update the attribute value of the selection attribute. > // This will also call MathMLSelectElement::attributeChanged to update the selected child. I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. Comment on attachment 219326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review r=me >> Source/WebCore/mathml/MathMLSelectElement.cpp:161 >> // This will also call MathMLSelectElement::attributeChanged to update the selected child. > > I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. Your choice. Leaving cq? set. Comment on attachment 219326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review >>> Source/WebCore/mathml/MathMLSelectElement.cpp:161 >>> // This will also call MathMLSelectElement::attributeChanged to update the selected child. >> >> I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. > > Your choice. Leaving cq? set. I’ll come back and do that later. Comment on attachment 219326 [details] Patch Clearing flags on attachment: 219326 Committed r160771: <http://trac.webkit.org/changeset/160771> All reviewed patches have been landed. Closing bug. |