Bug 125784

Summary: [iOS] Upstream WebCore/svg changes
Product: WebKit Reporter: Daniel Bates <dbates>
Component: SVGAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, ddkilzer, d-r, fmalita, gyuyoung.kim, pdr, schenney, thorton, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Daniel Bates 2013-12-16 09:26:21 PST 
Upstream the iOS related changes to WebCore/svg.
Comment 1 Daniel Bates 2013-12-16 09:28:53 PST 
Created attachment 219323 [details]
Patch
Comment 2 Darin Adler 2013-12-16 09:44:48 PST 
Comment on attachment 219323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review

> Source/WebCore/svg/SVGAElement.cpp:239
> +#if PLATFORM(IOS)
> +bool SVGAElement::willRespondToMouseClickEvents()

I see no reason for this to be iOS-specific. Seems like we want it on all platforms.

> Source/WebCore/svg/SVGAElement.cpp:241
> +    return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); 

Should check isLink() rather than !href().isEmpty().

> Source/WebCore/svg/SVGElement.cpp:494
> +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)

Not sure I understand why the PLATFORM(IOS) is here.
Comment 3 Daniel Bates 2013-12-16 15:21:32 PST 
(In reply to comment #2)
> (From update of attachment 219323 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review
> 
> > Source/WebCore/svg/SVGAElement.cpp:239
> > +#if PLATFORM(IOS)
> > +bool SVGAElement::willRespondToMouseClickEvents()
> 
> I see no reason for this to be iOS-specific. Seems like we want it on all platforms.

Will compile for all platforms.

> 
> > Source/WebCore/svg/SVGAElement.cpp:241
> > +    return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); 
> 
> Should check isLink() rather than !href().isEmpty().

Will substitute isLink() for !href().isEmpty().

> 
> > Source/WebCore/svg/SVGElement.cpp:494
> > +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)
> 
> Not sure I understand why the PLATFORM(IOS) is here.

Will remove conjunct PLATFORM(IOS).
Comment 4 Daniel Bates 2013-12-16 15:24:33 PST 
Committed r160668: <http://trac.webkit.org/changeset/160668>