| Summary: | [EFL] Make FTL buildable | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dániel Bátyai <dbatyai.u-szeged> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, gyuyoung.kim, ossy, pmolnar.u-szeged, rakuco, rniwa, zherczeg | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dániel Bátyai
2013-12-16 06:26:42 PST
Created attachment 219309 [details]
Proposed patch
Attachment 219309 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLOSREntry.cpp', u'Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp', u'Source/JavaScriptCore/llvm/library/config_llvm.h', u'Source/cmake/OptionsEfl.cmake', u'Source/cmakeconfig.h.cmake', '--commit-queue']" exit_code: 1
ERROR: ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:593: Alphabetical sorting problem. "ftl/FTLOSRExit.cpp" should be before "ftl/FTLOSRExitCompiler.cpp". [list/order] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:617: There should be exactly one empty line instead of 0 between "bytecode" and "collector/handles". [list/emptyline] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:618: Alphabetical sorting problem. "debugger" should be before "collector/handles". [list/order] [5]
Total errors found: 6 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 219310 [details]
Proposed patch
Created attachment 219315 [details]
Proposed patch
Some files were missing from the previous patch
Attachment 219315 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/llvm/InitializeLLVMLinux.cpp', u'Source/JavaScriptCore/llvm/library/config_llvm.h', u'Source/cmake/FindLLVM.cmake', u'Source/cmake/OptionsEfl.cmake', u'Source/cmakeconfig.h.cmake', '--commit-queue']" exit_code: 1
ERROR: Source/cmake/FindLLVM.cmake:12: No space before ")" [whitespace/parentheses] [5]
ERROR: Source/cmake/FindLLVM.cmake:13: No space before ")" [whitespace/parentheses] [5]
ERROR: Source/cmake/FindLLVM.cmake:14: No space before ")" [whitespace/parentheses] [5]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 219317 [details]
Proposed patch
Comment on attachment 219317 [details]
Proposed patch
LGTM, r=me.
Comment on attachment 219317 [details] Proposed patch Clearing flags on attachment: 219317 Committed r161498: <http://trac.webkit.org/changeset/161498> All reviewed patches have been landed. Closing bug. |