Summary: | CTTE: Convert more of SVG to use references | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, schenney | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sam Weinig
2013-12-15 19:19:10 PST
Created attachment 219289 [details]
Patch
Comment on attachment 219289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219289&action=review > Source/WebCore/rendering/svg/RenderSVGResource.cpp:179 > + if (RenderElement* renderer = element->renderer()) Could use auto instead of specifying RenderElement. Other places in the patch, too. Created attachment 219292 [details]
Patch
Comment on attachment 219292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219292&action=review Looks great. I spotted 6 “other places” you didn’t change. > Source/WebCore/svg/SVGAnimateMotionElement.cpp:292 > + if (RenderElement* renderer = targetElement->renderer()) One of the “other places”. > Source/WebCore/svg/SVGAnimateMotionElement.cpp:307 > + if (RenderElement* renderer = shadowTreeElement->renderer()) { Another of the “other places”. > Source/WebCore/svg/SVGFEImageElement.cpp:202 > + RenderElement* parentRenderer = parent->renderer(); Another of the “other places”. > Source/WebCore/svg/SVGFELightElement.cpp:217 > + RenderElement* renderer = parent->renderer(); Another of the “other places”. > Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp:168 > + RenderElement* renderer = parent->renderer(); Another of the “other places”. > Source/WebCore/svg/SVGSVGElement.cpp:726 > + if (RenderElement* renderer = svg->renderer()) Another of the “other places”. (In reply to comment #4) > (From update of attachment 219292 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219292&action=review > > Looks great. I spotted 6 “other places” you didn’t change. > > > Source/WebCore/svg/SVGAnimateMotionElement.cpp:292 > > + if (RenderElement* renderer = targetElement->renderer()) > > One of the “other places”. > > > Source/WebCore/svg/SVGAnimateMotionElement.cpp:307 > > + if (RenderElement* renderer = shadowTreeElement->renderer()) { > > Another of the “other places”. > > > Source/WebCore/svg/SVGFEImageElement.cpp:202 > > + RenderElement* parentRenderer = parent->renderer(); > > Another of the “other places”. > > > Source/WebCore/svg/SVGFELightElement.cpp:217 > > + RenderElement* renderer = parent->renderer(); > > Another of the “other places”. > > > Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp:168 > > + RenderElement* renderer = parent->renderer(); > > Another of the “other places”. > > > Source/WebCore/svg/SVGSVGElement.cpp:726 > > + if (RenderElement* renderer = svg->renderer()) > > Another of the “other places”. Doh. I'll get them in another pass. Comment on attachment 219292 [details] Patch Clearing flags on attachment: 219292 Committed r160651: <http://trac.webkit.org/changeset/160651> All reviewed patches have been landed. Closing bug. |