| Summary: | [iOS] Upstream changes to WebKit Public and Private headers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mitz | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andy Estes
2013-12-14 17:31:40 PST
Created attachment 219264 [details]
[iOS] Upstream changes to WebKit Public and Private headers
Comment on attachment 219264 [details] [iOS] Upstream changes to WebKit Public and Private headers View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review > Source/WebKit/mac/Misc/WebLocalizableStrings.h:41 > +#if TARGET_OS_IPHONE > +#if defined(__cplusplus) > +extern "C" { > +#endif > +#endif Can this be done unconditionally? (In reply to comment #2) > (From update of attachment 219264 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review > > > Source/WebKit/mac/Misc/WebLocalizableStrings.h:41 > > +#if TARGET_OS_IPHONE > > +#if defined(__cplusplus) > > +extern "C" { > > +#endif > > +#endif > > Can this be done unconditionally? Yes, I think so. Thanks for the review! (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 219264 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=219264&action=review > > > > > Source/WebKit/mac/Misc/WebLocalizableStrings.h:41 > > > +#if TARGET_OS_IPHONE > > > +#if defined(__cplusplus) > > > +extern "C" { > > > +#endif > > > +#endif > > > > Can this be done unconditionally? > > Yes, I think so. > > Thanks for the review! Actually, it duplicates an unconditional extern "C" that already exists, so I'll just remove it. Committed r160622: <http://trac.webkit.org/changeset/160622> |