Bug 125727

Summary: FTL should know the actual frame size of LLVM generated code
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: REOPENED    
Severity: Normal CC: atrick, barraclough, basile_clement, beidson, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 113621    
Attachments:
Description Flags
Patch beidson: review-, beidson: commit-queue-

Filip Pizlo
Reported 2013-12-13 20:42:03 PST
For now, we'll just guess that it's 1000 slots (slots = 8 bytes).
Attachments
Patch (1.37 KB, patch)
2015-09-04 09:37 PDT, Basile Clement 		beidson: review-
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-01-30 13:29:18 PST
This will just get fixed when we do the real stack check. *** This bug has been marked as a duplicate of bug 125650 ***
Basile Clement
Comment 2 2015-09-03 18:49:52 PDT
DFGCommon::frameRegisterCount is still 1000.
Basile Clement
Comment 3 2015-09-04 09:37:23 PDT
Created attachment 260592 [details] Patch
Brady Eidson
Comment 4 2017-04-24 19:09:34 PDT
Comment on attachment 260592 [details] Patch This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.
Note You need to log in before you can comment on or make changes to this bug.