Bug 125726

Summary: [WK2] Rename WebString to API::String
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Sam Weinig 2013-12-13 20:32:04 PST
[WK2] Rename WebString to API::String
Comment 1 Sam Weinig 2013-12-13 20:34:06 PST
Created attachment 219227 [details]
Patch
Comment 2 Andreas Kling 2013-12-14 02:52:51 PST
Comment on attachment 219227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review

> Source/WebKit2/Shared/APIString.h:53
> -        return adoptRef(new WebString(string));
> +        return adoptRef(new String(String(jsStringRef->string())));

This looks weird.
Comment 3 Sam Weinig 2013-12-14 10:01:47 PST
(In reply to comment #2)
> (From update of attachment 219227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review
> 
> > Source/WebKit2/Shared/APIString.h:53
> > -        return adoptRef(new WebString(string));
> > +        return adoptRef(new String(String(jsStringRef->string())));
> 
> This looks weird.

Indeed.
Comment 4 Sam Weinig 2013-12-14 10:32:08 PST
Created attachment 219253 [details]
Patch
Comment 5 Sam Weinig 2013-12-14 17:06:37 PST
Committed r160608: <http://trac.webkit.org/changeset/160608>