Summary: | [WK2] Rename WebString to API::String | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sam Weinig
2013-12-13 20:32:04 PST
Created attachment 219227 [details]
Patch
Comment on attachment 219227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review > Source/WebKit2/Shared/APIString.h:53 > - return adoptRef(new WebString(string)); > + return adoptRef(new String(String(jsStringRef->string()))); This looks weird. (In reply to comment #2) > (From update of attachment 219227 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review > > > Source/WebKit2/Shared/APIString.h:53 > > - return adoptRef(new WebString(string)); > > + return adoptRef(new String(String(jsStringRef->string()))); > > This looks weird. Indeed. Created attachment 219253 [details]
Patch
Committed r160608: <http://trac.webkit.org/changeset/160608> |