Bug 125726

Summary: [WK2] Rename WebString to API::String
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2013-12-13 20:32:04 PST
[WK2] Rename WebString to API::String
Attachments
Patch (70.61 KB, patch)
2013-12-13 20:34 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (70.62 KB, patch)
2013-12-14 10:32 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-12-13 20:34:06 PST
Created attachment 219227 [details] Patch
Andreas Kling
Comment 2 2013-12-14 02:52:51 PST
Comment on attachment 219227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review > Source/WebKit2/Shared/APIString.h:53 > - return adoptRef(new WebString(string)); > + return adoptRef(new String(String(jsStringRef->string()))); This looks weird.
Sam Weinig
Comment 3 2013-12-14 10:01:47 PST
(In reply to comment #2) > (From update of attachment 219227 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review > > > Source/WebKit2/Shared/APIString.h:53 > > - return adoptRef(new WebString(string)); > > + return adoptRef(new String(String(jsStringRef->string()))); > > This looks weird. Indeed.
Sam Weinig
Comment 4 2013-12-14 10:32:08 PST
Created attachment 219253 [details] Patch
Sam Weinig
Comment 5 2013-12-14 17:06:37 PST
Committed r160608: <http://trac.webkit.org/changeset/160608>
Note You need to log in before you can comment on or make changes to this bug.