Bug 125726 - [WK2] Rename WebString to API::String
Summary: [WK2] Rename WebString to API::String
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-13 20:32 PST by Sam Weinig
Modified: 2013-12-14 17:06 PST (History)
0 users

See Also:

Attachments
Patch (70.61 KB, patch)
2013-12-13 20:34 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (70.62 KB, patch)
2013-12-14 10:32 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-12-13 20:32:04 PST 
[WK2] Rename WebString to API::String
Comment 1 Sam Weinig 2013-12-13 20:34:06 PST 
Created attachment 219227 [details]
Patch
Comment 2 Andreas Kling 2013-12-14 02:52:51 PST 
Comment on attachment 219227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review

> Source/WebKit2/Shared/APIString.h:53
> -        return adoptRef(new WebString(string));
> +        return adoptRef(new String(String(jsStringRef->string())));

This looks weird.
Comment 3 Sam Weinig 2013-12-14 10:01:47 PST 
(In reply to comment #2)
> (From update of attachment 219227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219227&action=review
> 
> > Source/WebKit2/Shared/APIString.h:53
> > -        return adoptRef(new WebString(string));
> > +        return adoptRef(new String(String(jsStringRef->string())));
> 
> This looks weird.

Indeed.
Comment 4 Sam Weinig 2013-12-14 10:32:08 PST 
Created attachment 219253 [details]
Patch
Comment 5 Sam Weinig 2013-12-14 17:06:37 PST 
Committed r160608: <http://trac.webkit.org/changeset/160608>