Bug 125721

Summary: [Cocoa] Expose some layout milestones
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add -browsingContextController:renderingProgressDidChange: sam: review+

mitz
Reported 2013-12-13 19:04:14 PST
[Cocoa] Expose some layout milestones
Attachments
Add -browsingContextController:renderingProgressDidChange: (5.74 KB, patch)
2013-12-13 19:09 PST, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-12-13 19:09:28 PST
Created attachment 219220 [details] Add -browsingContextController:renderingProgressDidChange:
WebKit Commit Bot
Comment 2 2013-12-13 19:11:05 PST
Attachment 219220 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:39: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2013-12-14 15:21:49 PST
Committed <http://trac.webkit.org/r160602>.
Simon Fraser (smfr)
Comment 4 2013-12-15 10:09:40 PST
This broke the 32-bit build: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100
mitz
Comment 5 2013-12-15 10:13:34 PST
(In reply to comment #4) > This broke the 32-bit build: > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100 Attempted fix in <http://trac.webkit.org/r160619>.
mitz
Comment 6 2013-12-15 10:20:39 PST
More fixes coming up
mitz
Comment 7 2013-12-15 10:24:56 PST
TestWebKitAPI fix in <http://trac.webkit.org/r160620>.
Note You need to log in before you can comment on or make changes to this bug.