| Summary: | [Cocoa] Expose some layout milestones | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | WebKit2 | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2013-12-13 19:04:14 PST
Created attachment 219220 [details]
Add -browsingContextController:renderingProgressDidChange:
Attachment 219220 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:39: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed <http://trac.webkit.org/r160602>. This broke the 32-bit build: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100 (In reply to comment #4) > This broke the 32-bit build: > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100 Attempted fix in <http://trac.webkit.org/r160619>. More fixes coming up TestWebKitAPI fix in <http://trac.webkit.org/r160620>. |