Bug 125716

Summary: [Mac] Cache partitioning asserts when associated NSURLRequest is nil
Product: WebKit Reporter: Vicki Pfau <jeffrey+webkit>
Component: Page LoadingAssignee: Vicki Pfau <jeffrey+webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: OS X 10.9   
Attachments:
Description Flags
Patch darin: review+

Vicki Pfau
Reported 2013-12-13 15:59:47 PST
In some cases, a ResourceRequest may attempt to update the cache partition when the associated NSURLRequest is nil. This will trigger an assertion. <rdar://problem/15375976>
Attachments
Patch (1.61 KB, patch)
2013-12-13 16:03 PST, Vicki Pfau 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vicki Pfau
Comment 1 2013-12-13 16:03:26 PST
Created attachment 219207 [details] Patch
Vicki Pfau
Comment 2 2013-12-16 14:38:51 PST
Committed r160663: <http://trac.webkit.org/changeset/160663>
Alexey Proskuryakov
Comment 3 2013-12-16 15:26:09 PST
Comment on attachment 219207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219207&action=review > Source/WebCore/platform/network/mac/ResourceRequestMac.mm:114 > + m_cachePartition = cachePartition; Does m_cachePartition need to be reset to null when m_nsRequest is null?
Vicki Pfau
Comment 4 2013-12-16 15:28:09 PST
(In reply to comment #3) > (From update of attachment 219207 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219207&action=review > > > Source/WebCore/platform/network/mac/ResourceRequestMac.mm:114 > > + m_cachePartition = cachePartition; > > Does m_cachePartition need to be reset to null when m_nsRequest is null? Since it doesn't reset m_cachePartition to null when the partition it gets out of the request is null either, I don't think this is necessary, but that might itself be a bug.
Note You need to log in before you can comment on or make changes to this bug.