Summary: | Web Inspector: Move Inspector and Debugger protocol domains into JavaScriptCore | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, graouts, gyuyoung.kim, joepeck, rakuco, rniwa, timothy, webkit-bug-importer, zan | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2013-12-13 13:15:07 PST
Created attachment 219191 [details]
[PATCH] Proposed Fix
Comment on attachment 219191 [details] [PATCH] Proposed Fix Attachment 219191 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/48638260 New failing tests: inspector-protocol/debugger/setBreakpoint-options-exception.html inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html inspector-protocol/debugger/breakpoint-action-detach.html inspector-protocol/debugger/breakpoint-action-with-exception.html inspector-protocol/debugger/setBreakpoint-actions.html Created attachment 219205 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
That sounds like a red flag! I'll investigate. Comment on attachment 219191 [details] [PATCH] Proposed Fix Attachment 219191 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/48628268 New failing tests: inspector-protocol/debugger/setBreakpoint-options-exception.html inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html inspector-protocol/debugger/breakpoint-action-detach.html inspector-protocol/debugger/breakpoint-action-with-exception.html inspector-protocol/debugger/setBreakpoint-actions.html Created attachment 219206 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 219208 [details]
[DIFF] Extra Changes
These are the changes I have to make to fix the issue seen in inspector-protocol/debugger tests.
I have no idea how the compiler was compiling this without warnings. This had crossed my mind before, and these test failures just made it very obvious.
There were two Inspector::TypeBuilder::getEnumConstantValue functions, now there will be one for each TypeBuilder output file. So:
Inspector::TypeBuilder::getJSEnumConstantValue(...)
Inspector::TypeBuilder::getWebEnumConstantValue(...)
Created attachment 219211 [details]
[PATCH] Improved Fix
|