Bug 125703

Summary: [MSE] Update duration after appending samples, per spec.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2013-12-13 12:54:33 PST
[MSE] Update duration after appending samples, per spec.
Attachments
Patch (7.06 KB, patch)
2013-12-13 13:04 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-12-13 13:04:46 PST
Created attachment 219187 [details] Patch
Eric Carlson
Comment 2 2013-12-13 14:53:40 PST
Comment on attachment 219187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219187&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1010 > + if (highestPresentationEndTimestamp().toDouble() > m_source->duration()) > + m_source->setDuration(highestPresentationEndTimestamp().toDouble(), IgnorableExceptionCode()); Nit: it will be more efficient to put the timestamp in a variable instead of calculating it twice. > LayoutTests/media/media-source/media-source-duration-after-append.html:16 > + function runTest() { Nit: wrong place for the opening brace.
WebKit Commit Bot
Comment 3 2013-12-17 16:54:29 PST
Comment on attachment 219187 [details] Patch Clearing flags on attachment: 219187 Committed r160739: <http://trac.webkit.org/changeset/160739>
WebKit Commit Bot
Comment 4 2013-12-17 16:54:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.