Bug 125699

Summary: [WK2] Start removing calls to String::characters()
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2013-12-13 12:44:46 PST 
[WK2] Start removing calls to String::characters()
Comment 1 Sam Weinig 2013-12-13 12:45:12 PST 
Created attachment 219182 [details]
Patch
Comment 2 Anders Carlsson 2013-12-13 12:47:54 PST 
Comment on attachment 219182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219182&action=review

> Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:55
> +    RetainPtr<CFStringRef> directoryCFString = directory.createCFString();

auto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:912
> +        loadDataImpl(sharedBuffer, MIMEType, ASCIILiteral("utf-8"), baseURL, unreachableURL, decoder);

This has to be latin-1.
Comment 3 Sam Weinig 2013-12-13 15:56:03 PST 
Committed r160572: <http://trac.webkit.org/changeset/160572>
Comment 4 Andreas Kling 2013-12-15 22:10:52 PST 
This broke some unit tests:

Tests that failed:
  WebKit2WillLoadTest.WKPageLoadAlternateHTMLString
  WebKit2WillLoadTest.WKPageLoadAlternateHTMLStringWithUserData
  WebKit2WillLoadTest.WKPageLoadHTMLString
  WebKit2WillLoadTest.WKPageLoadHTMLStringWithUserData
  WebKit2WillLoadTest.WKPageLoadPlainTextString
  WebKit2WillLoadTest.WKPageLoadPlainTextStringWithUserData
Tests that timed out:
  WKBrowsingContextLoadDelegateTest.SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL

The last one is still timing out on ToT:
  WKBrowsingContextLoadDelegateTest.SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL

http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/11839
Comment 5 Alexey Proskuryakov 2013-12-16 15:33:51 PST 
> The last one is still timing out on ToT:
>   WKBrowsingContextLoadDelegateTest.SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL

And still.

Filed bug 125810 about that.