| Summary: | Add page load delegate for WebProcessPlugInBrowsingContextController. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, commit-queue, mitz, ossy, sam, yongjun_zhang | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yongjun Zhang
2013-12-13 12:28:34 PST
Created attachment 219188 [details]
Add page load delegate to WKWebProcessPlugInBrowsingContextController.
Comment on attachment 219188 [details] Add page load delegate to WKWebProcessPlugInBrowsingContextController. View in context: https://bugs.webkit.org/attachment.cgi?id=219188&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:82 > +static void setUpPageLoaderClient(WKWebProcessPlugInBrowserContextController *contextController, WebPage &page) & on the wrong side. Created attachment 219270 [details]
address review comments before landing.
Comment on attachment 219270 [details] address review comments before landing. Clearing flags on attachment: 219270 Committed r160616: <http://trac.webkit.org/changeset/160616> All reviewed patches have been landed. Closing bug. Comment on attachment 219270 [details] address review comments before landing. View in context: https://bugs.webkit.org/attachment.cgi?id=219270&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:37 > +#import "WKWebProcessPluginFrameInternal.h" It's not WKWebProcessPlug_i_nFrameInternal.h, but WKWebProcessPlug_I_nFrameInternal.h Fixed in https://trac.webkit.org/changeset/208431 |