Bug 125691

Summary: [GTK] Expose also webkit_dom_document_get_url
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gustavo, jasuarez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2013-12-13 04:19:17 PST
For some reason we expose the URL property, so it can be accessed with g_object_get(), but we have a special case to not provide a public getter.
Attachments
Patch (2.41 KB, patch)
2013-12-13 04:21 PST, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-12-13 04:21:03 PST
Created attachment 219166 [details] Patch
Martin Robinson
Comment 2 2013-12-13 04:24:41 PST
Comment on attachment 219166 [details] Patch Were you able to figure out why the getter wasn't exposed?
Carlos Garcia Campos
Comment 3 2013-12-13 04:31:08 PST
(In reply to comment #2) > (From update of attachment 219166 [details]) > Were you able to figure out why the getter wasn't exposed? Nope, looked at git blame and that exception is there since the very beginning. My guess is that the property was added and the check for the public method was forgotten.
Carlos Garcia Campos
Comment 4 2013-12-13 04:37:09 PST
Committed r160543: <http://trac.webkit.org/changeset/160543>
Note You need to log in before you can comment on or make changes to this bug.