Bug 125683

Summary: [GTK] [CMake] Build the WebKit2 GObject API tests
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115966    
Attachments:
Description Flags
Patch
none
Patch gustavo: review-

Martin Robinson
Reported 2013-12-13 00:50:17 PST
We need CMake to build the WebKit2 GObject API tests.
Attachments
Patch (9.07 KB, patch)
2013-12-22 11:39 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (18.03 KB, patch)
2013-12-22 11:40 PST, Martin Robinson 		gustavo: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-12-22 11:39:55 PST
Created attachment 219878 [details] Patch
Martin Robinson
Comment 2 2013-12-22 11:40:38 PST
Created attachment 219879 [details] Patch
Gustavo Noronha (kov)
Comment 3 2013-12-22 12:50:09 PST
Comment on attachment 219879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219879&action=review hmm I'm confuse. This seems to also add the wk1 version of the GObject API tests! > Source/PlatformGTK.cmake:3 > +if (ENABLE_WEBKIT) > + add_subdirectory(${WEBKIT_DIR}/gtk/tests) > +endif () This actually makes more sense than the patch I r+ed in the other bug heh.
Martin Robinson
Comment 4 2013-12-22 13:11:33 PST
Comment on attachment 219878 [details] Patch Looks like I tried to get a bit too fancy with webkit-patch. I managed to upload the wrong patch to this bug and obsolete the real patch.
Martin Robinson
Comment 5 2013-12-22 13:11:55 PST
Comment on attachment 219878 [details] Patch The patch marked for review should be the real one now.
Daniel Bates
Comment 6 2013-12-23 13:10:04 PST
Comment on attachment 219879 [details] Patch Obsoleting patch per comment 5.
Daniel Bates
Comment 7 2013-12-23 13:30:28 PST
Comment on attachment 219878 [details] Patch This looks sane to me.
Martin Robinson
Comment 8 2013-12-23 13:46:17 PST
Comment on attachment 219878 [details] Patch Clearing flags on attachment: 219878 Committed r161016: <http://trac.webkit.org/changeset/161016>
Martin Robinson
Comment 9 2013-12-23 13:46:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.