| Summary: | [GTK] [CMake] Build the WebKit2 GObject API tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
| Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, gyuyoung.kim, rakuco | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 115966 | ||||||||
| Attachments: |
|
||||||||
|
Description
Martin Robinson
2013-12-13 00:50:17 PST
Created attachment 219878 [details]
Patch
Created attachment 219879 [details]
Patch
Comment on attachment 219879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219879&action=review hmm I'm confuse. This seems to also add the wk1 version of the GObject API tests! > Source/PlatformGTK.cmake:3 > +if (ENABLE_WEBKIT) > + add_subdirectory(${WEBKIT_DIR}/gtk/tests) > +endif () This actually makes more sense than the patch I r+ed in the other bug heh. Comment on attachment 219878 [details]
Patch
Looks like I tried to get a bit too fancy with webkit-patch. I managed to upload the wrong patch to this bug and obsolete the real patch.
Comment on attachment 219878 [details]
Patch
The patch marked for review should be the real one now.
Comment on attachment 219879 [details] Patch Obsoleting patch per comment 5. Comment on attachment 219878 [details]
Patch
This looks sane to me.
Comment on attachment 219878 [details] Patch Clearing flags on attachment: 219878 Committed r161016: <http://trac.webkit.org/changeset/161016> All reviewed patches have been landed. Closing bug. |