Bug 125664

Summary: Web Inspector: Fix Type Dependency Issues
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, burg, commit-queue, joepeck, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2013-12-12 15:48:14 PST 
There are some type dependency issues where Domains in JavaScriptCore depended on types in WebCore.

We should come up with proper fixes for these issues, so that we can safely share the types between all places.

At the moment, my intended workaround has been to duplicate the type with different names in JSC and WebCore.
Comment 1 Joseph Pecoraro 2013-12-12 15:54:24 PST 
• Runtime.RuntimeFrameId duplicates Network.FrameId
• Debugger.DebuggerSearchMatch duplicates Page.SearchMatch

One approach would be to just reverse the dependency, and define it in the lower domain. However I think this may need to addressed on a case by case basis:

    • FrameId doesn't belong in Runtime. Maybe a more generic type name should used.
    • SearchMatch doesn't need to be in a specific domain. Maybe we should have a place of shared types everywhere. E.g. a Type domain which has no commands, just very generic types.
Comment 2 Radar WebKit Bug Importer 2014-10-29 17:42:56 PDT 
<rdar://problem/18819515>
Comment 3 Joseph Pecoraro 2014-10-29 17:43:02 PDT 
Created attachment 240643 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2014-10-29 17:44:07 PDT 
(In reply to comment #1)
> • Debugger.DebuggerSearchMatch duplicates Page.SearchMatch

This was worked around by GenericTypes.json. I'll keep that for now, I think its a worthwhile concept.
Comment 5 Brian Burg 2014-10-29 18:50:32 PDT 
Comment on attachment 240643 [details]
[PATCH] Proposed Fix

Thanks for the cleanup!
Comment 6 WebKit Commit Bot 2014-10-29 19:29:39 PDT 
Comment on attachment 240643 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 240643

Committed r175362: <http://trac.webkit.org/changeset/175362>
Comment 7 WebKit Commit Bot 2014-10-29 19:29:42 PDT 
All reviewed patches have been landed.  Closing bug.