Summary: | Add a few more ASCIILiterals | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, joepeck, timothy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2013-12-12 15:14:45 PST
Created attachment 219127 [details]
[PATCH] Proposed Fix
Comment on attachment 219127 [details]
[PATCH] Proposed Fix
OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size.
(In reply to comment #2) > (From update of attachment 219127 [details]) > OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size. Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 219127 [details] [details]) > > OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size. > > Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*. Wow, horrible English. Not* shown ... if the argument* was ... Comment on attachment 219127 [details] [PATCH] Proposed Fix Clearing flags on attachment: 219127 Committed r160523: <http://trac.webkit.org/changeset/160523> All reviewed patches have been landed. Closing bug. |