Bug 125662

Summary: Add a few more ASCIILiterals
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2013-12-12 15:14:45 PST 
Some string constants are turning into WTF::Strings, so they can use ASCIILiteral. They eventually get put into an InspectorObject.
Comment 1 Joseph Pecoraro 2013-12-12 15:15:57 PST 
Created attachment 219127 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2013-12-12 17:49:00 PST 
Comment on attachment 219127 [details]
[PATCH] Proposed Fix

OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size.
Comment 3 Joseph Pecoraro 2013-12-12 17:58:49 PST 
(In reply to comment #2)
> (From update of attachment 219127 [details])
> OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size.

Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*.
Comment 4 Joseph Pecoraro 2013-12-12 18:05:40 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 219127 [details] [details])
> > OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size.
> 
> Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*.

Wow, horrible English.

  Not* shown ... if the argument* was ...
Comment 5 WebKit Commit Bot 2013-12-12 18:16:22 PST 
Comment on attachment 219127 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 219127

Committed r160523: <http://trac.webkit.org/changeset/160523>
Comment 6 WebKit Commit Bot 2013-12-12 18:16:24 PST 
All reviewed patches have been landed.  Closing bug.