Bug 125657

Summary: Fix a silly mistake of r160467
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Description Benjamin Poulain 2013-12-12 14:40:01 PST
Fix a silly mistake of r160467
Comment 1 Benjamin Poulain 2013-12-12 14:41:16 PST
Created attachment 219121 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-12-12 15:04:26 PST
Comment on attachment 219121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219121&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:136
> +        if (!!protector->hasHandle()) {

Can we just use "if (protector->hasHandle())"?

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:164
> -        if (!protector->hasHandle()) {
> +        if (!!protector->hasHandle()) {

Ditto

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:197
> +        if (!!protector->hasHandle()) {

Ditto.

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:272
> +        if (!!protector->hasHandle()) {

Ditto
Comment 3 Benjamin Poulain 2013-12-12 16:29:17 PST
(In reply to comment #2)
> (From update of attachment 219121 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219121&action=review
> 
> > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:136
> > +        if (!!protector->hasHandle()) {
> 
> Can we just use "if (protector->hasHandle())"?

Of course :)
Will fix.
Comment 4 Benjamin Poulain 2013-12-12 19:50:42 PST
Committed r160525: <http://trac.webkit.org/changeset/160525>