Bug 125618

Summary: Remove some unneeded code noticed while looking at StylePendingImage
Product: WebKit Reporter: Darin Adler <darin>
Component: CSSAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Darin Adler
Reported 2013-12-11 23:55:48 PST
Remove some unneeded code noticed while looking at StylePendingImage
Attachments
Patch (6.20 KB, patch)
2013-12-11 23:58 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (6.17 KB, patch)
2013-12-12 00:10 PST, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-12-11 23:58:02 PST
Created attachment 219048 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-12 00:00:27 PST
Attachment 219048 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2013-12-12 00:10:21 PST
Created attachment 219049 [details] Patch
Andreas Kling
Comment 4 2013-12-12 00:20:31 PST
Comment on attachment 219049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219049&action=review r=me > Source/WebCore/css/StyleResolver.cpp:3881 > + if (CSSImageValue* imageValue = pendingImage->cssImageValue()) auto > Source/WebCore/css/StyleResolver.cpp:3884 > + if (CSSImageGeneratorValue* imageGeneratorValue = pendingImage->cssImageGeneratorValue()) { auto > Source/WebCore/css/StyleResolver.cpp:3889 > + if (CSSCursorImageValue* cursorImageValue = pendingImage->cssCursorImageValue()) auto > Source/WebCore/css/StyleResolver.cpp:3893 > + if (CSSImageSetValue* imageSetValue = pendingImage->cssImageSetValue()) auto
Darin Adler
Comment 5 2013-12-12 00:41:25 PST
Committed r160478: <http://trac.webkit.org/changeset/160478>
Note You need to log in before you can comment on or make changes to this bug.