Bug 125598

Summary: Give Unique StringImpls a meaningful data pointer
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch msaboff: review+

Oliver Hunt
Reported 2013-12-11 13:44:32 PST
Give Unique StringImpls a meaningful data pointer
Attachments
Patch (1.78 KB, patch)
2013-12-11 13:48 PST, Oliver Hunt 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-12-11 13:48:13 PST
Created attachment 219000 [details] Patch
Michael Saboff
Comment 2 2013-12-11 13:52:44 PST
Comment on attachment 219000 [details] Patch r=me, but add a comment in the code that we expect m_buffer to be null. If we change StringImpl in the future it will be easier to see why you're doing this without tracking down the change set / bug.
Oliver Hunt
Comment 3 2013-12-11 14:04:08 PST
Committed r160453: <http://trac.webkit.org/changeset/160453>
Note You need to log in before you can comment on or make changes to this bug.