Bug 125584

Summary: [ATK] Expose accessibility objects WAI-ARIA landmark roles
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 125493    
Attachments:
Description Flags
Patch proposal
none
Patch proposal cfleizach: review+

Mario Sanchez Prada
Reported 2013-12-11 10:44:46 PST
This includes: * <address> * <aside> * <header> * <nav> * <div role="banner"> * <div role="complementary"> * <div role="contentinfo"> * <div role="main"> * <div role="navigation"> * <div role="search">
Attachments
Patch proposal (20.60 KB, patch)
2013-12-11 10:55 PST, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
Patch proposal (20.69 KB, patch)
2013-12-11 11:36 PST, Mario Sanchez Prada 		cfleizach: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2013-12-11 10:55:36 PST
Created attachment 218977 [details] Patch proposal
chris fleizach
Comment 2 2013-12-11 11:20:52 PST
Comment on attachment 218977 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=218977&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:534 > + if (role == LandmarkBannerRole) we should use a switch statement here > Tools/gtk/jhbuild.modules:235 > + <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.3.tar.xz" version="2.11.3" seems like this should be in a different patch
Mario Sanchez Prada
Comment 3 2013-12-11 11:26:46 PST
(In reply to comment #2) > (From update of attachment 218977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218977&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:534 > > + if (role == LandmarkBannerRole) > > we should use a switch statement here Ok > > Tools/gtk/jhbuild.modules:235 > > + <branch module="pub/GNOME/sources/atk/2.11/atk-2.11.3.tar.xz" version="2.11.3" > > seems like this should be in a different patch I think it's better to have it in this one, since we need to bump that new version in the jhbuild because of this patch
Mario Sanchez Prada
Comment 4 2013-12-11 11:36:58 PST
Created attachment 218986 [details] Patch proposal New patch with the switch statement
chris fleizach
Comment 5 2013-12-11 11:39:33 PST
Comment on attachment 218986 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=218986&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:532 > + // of LandMarkApplicationRole, whic will be exposed with ATK_ROLE_EMBEDDED. should be LandmarkApplicationRole which spelled wrong
Mario Sanchez Prada
Comment 6 2013-12-11 11:42:01 PST
(In reply to comment #5) > (From update of attachment 218986 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218986&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:532 > > + // of LandMarkApplicationRole, whic will be exposed with ATK_ROLE_EMBEDDED. > > should be LandmarkApplicationRole > > which spelled wrong I'll fix it before landing. Thanks
Mario Sanchez Prada
Comment 7 2013-12-11 11:46:52 PST
Committed r160450: <http://trac.webkit.org/changeset/160450>
Note You need to log in before you can comment on or make changes to this bug.