Summary: | Adding RTCPeerConnectionErrorCallback | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||||||||||
Component: | WebCore Misc. | Assignee: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, hta, jer.noble, kondapallykalyan, pnormand, rakuco, rego+ews, rniwa, tommyw, xan.lopez | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 125568 | ||||||||||||||||
Bug Blocks: | 124288, 125655 | ||||||||||||||||
Attachments: |
|
Description
Thiago de Barros Lacerda
2013-12-11 07:19:27 PST
Created attachment 218967 [details]
Patch
Comment on attachment 218967 [details]
Patch
Seems like this is not rebased on top of ToT ?
Looks good otherwise (In reply to comment #3) > Looks good otherwise Hey Philippe, that's because it depends on https://bugs.webkit.org/show_bug.cgi?id=125568. Could you take a look on it as well? Created attachment 218968 [details]
Patch
Comment on attachment 218968 [details] Patch Attachment 218968 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47308534 Created attachment 218972 [details]
Patch
with Xcode project update
Comment on attachment 218968 [details]
Patch
Didn't pass mac EWS
Comment on attachment 218972 [details] Patch Attachment 218972 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47348348 Comment on attachment 218972 [details] Patch Attachment 218972 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/47208575 Comment on attachment 218972 [details] Patch Attachment 218972 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/45888560 Created attachment 218978 [details]
Patch
Comment on attachment 218978 [details] Patch Attachment 218978 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47438176 Comment on attachment 218978 [details] Patch Attachment 218978 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/45658027 Comment on attachment 218978 [details] Patch Attachment 218978 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47008146 Comment on attachment 218978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218978&action=review > LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html:26 > errorReason = reason; > - shouldBe('errorReason', '"TEST_ERROR"'); > + shouldBe('errorReason.name', '"IncompatibleConstraintsError"'); Is it possible to create tests for the other new errors? Created attachment 219069 [details]
Patch
with Xcode project update
(In reply to comment #16) > (From update of attachment 218978 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218978&action=review > > > LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html:26 > > errorReason = reason; > > - shouldBe('errorReason', '"TEST_ERROR"'); > > + shouldBe('errorReason.name', '"IncompatibleConstraintsError"'); > > Is it possible to create tests for the other new errors? Yes Eric, I'm now working on a patch for them. I didn't not put on this because it would increase the size of the patch too much. Are you OK with another patch? (In reply to comment #18) > (In reply to comment #16) > > (From update of attachment 218978 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=218978&action=review > > > > > LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html:26 > > > errorReason = reason; > > > - shouldBe('errorReason', '"TEST_ERROR"'); > > > + shouldBe('errorReason.name', '"IncompatibleConstraintsError"'); > > > > Is it possible to create tests for the other new errors? > > Yes Eric, I'm now working on a patch for them. I didn't not put on this because it would increase the size of the patch too much. Are you OK with another patch? That seems fine. Please include a FIXME: with a bug number so someone reading the patch knows what the plan is. Created attachment 219113 [details]
Patch
Seems like a FIXME is missing or we assume it's the bug blocked by this one? (In reply to comment #21) > Seems like a FIXME is missing or we assume it's the bug blocked by this one? It's the bug blocked by this one Comment on attachment 219113 [details] Patch Clearing flags on attachment: 219113 Committed r160553: <http://trac.webkit.org/changeset/160553> All reviewed patches have been landed. Closing bug. |