Bug 125570

Summary: Move ChildProcessProxy from Shared to UIProcess
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, cdumez, commit-queue, darin, gyuyoung.kim, kling, mcatanzaro, mkwst, rakuco, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebased patch none

Carlos Garcia Campos
Reported 2013-12-11 06:11:11 PST
It's only used by UIProcess.
Attachments
Patch (26.27 KB, patch)
2013-12-11 06:12 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Rebased patch (28.39 KB, patch)
2016-01-12 03:58 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-12-11 06:12:54 PST
Created attachment 218955 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-11 06:14:49 PST
Attachment 218955 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/Shared/ChildProcessProxy.cpp', u'Source/WebKit2/Shared/ChildProcessProxy.h', u'Source/WebKit2/UIProcess/ChildProcessProxy.cpp', u'Source/WebKit2/UIProcess/ChildProcessProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/UIProcess/ChildProcessProxy.h:51: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 3 2016-01-02 09:12:29 PST
Owners?
Darin Adler
Comment 4 2016-01-11 08:45:22 PST
Seems OK to me. But can you upload a patch that applies and builds?
Carlos Garcia Campos
Comment 5 2016-01-11 10:05:33 PST
Sure, I'll prepare a new patch
Carlos Garcia Campos
Comment 6 2016-01-12 03:58:46 PST
Created attachment 268756 [details] Rebased patch
WebKit Commit Bot
Comment 7 2016-01-12 09:23:42 PST
Comment on attachment 268756 [details] Rebased patch Clearing flags on attachment: 268756 Committed r194895: <http://trac.webkit.org/changeset/194895>
WebKit Commit Bot
Comment 8 2016-01-12 09:23:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.