Bug 125568

Summary: Improving createOffer and createAnswer LayoutTests
Product: WebKit Reporter: Thiago de Barros Lacerda <thiago.lacerda>
Component: WebCore Misc.Assignee: Thiago de Barros Lacerda <thiago.lacerda>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, hta, jer.noble, pnormand, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124288, 125574    
Attachments:
Description Flags
Patch
none
Patch none

Thiago de Barros Lacerda
Reported 2013-12-11 05:49:50 PST
The constraints parameter should be optional in both. Also adding tests to check if we already have a local SDP when creating an answer.
Attachments
Patch (11.80 KB, patch)
2013-12-11 06:01 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch (12.53 KB, patch)
2013-12-11 06:43 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-12-11 06:01:27 PST
Created attachment 218954 [details] Patch
Thiago de Barros Lacerda
Comment 2 2013-12-11 06:26:11 PST
In fact, the spec says that the check for local offer must be done when user is trying to set a description of type answer. I will modify this patch.
Thiago de Barros Lacerda
Comment 3 2013-12-11 06:28:08 PST
(In reply to comment #2) > In fact, the spec says that the check for local offer must be done when user is trying to set a description of type answer. I will modify this patch. Other patch for that would be better, since it will require to add some state tracking in RTCPeerConnectionHandlerMock
Thiago de Barros Lacerda
Comment 4 2013-12-11 06:43:20 PST
Created attachment 218959 [details] Patch
WebKit Commit Bot
Comment 5 2013-12-11 08:40:04 PST
Comment on attachment 218959 [details] Patch Clearing flags on attachment: 218959 Committed r160436: <http://trac.webkit.org/changeset/160436>
WebKit Commit Bot
Comment 6 2013-12-11 08:40:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.