Bug 125568

Summary:

Improving createOffer and createAnswer LayoutTests

Product:

WebKit

Reporter:

Thiago de Barros Lacerda <thiago.lacerda>

Component:

WebCore Misc.

Assignee:

Thiago de Barros Lacerda <thiago.lacerda>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, hta, jer.noble, pnormand, tommyw

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

124288, 125574

Attachments:

Description	Flags
Patch	none
Patch	none

Description Thiago de Barros Lacerda 2013-12-11 05:49:50 PST

The constraints parameter should be optional in both. Also adding tests to check if we already have a local SDP when creating an answer.

Comment 1 Thiago de Barros Lacerda 2013-12-11 06:01:27 PST

Created attachment 218954 [details]
Patch

Comment 2 Thiago de Barros Lacerda 2013-12-11 06:26:11 PST

In fact, the spec says that the check for local offer must be done when user is trying to set a description of type answer. I will modify this patch.

Comment 3 Thiago de Barros Lacerda 2013-12-11 06:28:08 PST

(In reply to comment #2)
> In fact, the spec says that the check for local offer must be done when user is trying to set a description of type answer. I will modify this patch.

Other patch for that would be better, since it will require to add some state tracking in RTCPeerConnectionHandlerMock

Comment 4 Thiago de Barros Lacerda 2013-12-11 06:43:20 PST

Created attachment 218959 [details]
Patch

Comment 5 WebKit Commit Bot 2013-12-11 08:40:04 PST

Comment on attachment 218959 [details]
Patch

Clearing flags on attachment: 218959

Committed r160436: <http://trac.webkit.org/changeset/160436>

Comment 6 WebKit Commit Bot 2013-12-11 08:40:07 PST

All reviewed patches have been landed.  Closing bug.