Bug 125512

Summary: [GTK][CMake] make libjavascriptcoregtk a public shared library again
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115966    
Attachments:
Description Flags
Patch
none
Patch mrobinson: review+

Description Gustavo Noronha (kov) 2013-12-10 07:17:52 PST 
Right now JSC is being built as an intermediate static library, we need to support shipping it as a shared library.
Comment 1 Gustavo Noronha (kov) 2013-12-18 13:38:13 PST 
Created attachment 219563 [details]
Patch
Comment 2 EFL EWS Bot 2013-12-18 14:30:01 PST 
Comment on attachment 219563 [details]
Patch

Attachment 219563 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/50478068
Comment 3 Gustavo Noronha (kov) 2013-12-18 14:56:15 PST 
Created attachment 219574 [details]
Patch
Comment 4 Martin Robinson 2013-12-18 15:10:11 PST 
Comment on attachment 219574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219574&action=review

> Source/JavaScriptCore/CMakeLists.txt:765
> +get_target_property(TARGET_TYPE JavaScriptCore TYPE)
> +if (${TARGET_TYPE} STREQUAL "SHARED_LIBRARY")

I think you can just do:

if (${JavaScriptCore_LIBRARY_TYPE} STREQUAL "SHARED")

here and avoid the get_target_property call.
Comment 5 Gustavo Noronha (kov) 2013-12-18 17:31:54 PST 
Committed r160812: <http://trac.webkit.org/changeset/160812>